Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests electronics/electric_conductivity.py #9943 #12437

Merged
merged 9 commits into from
Dec 30, 2024
Merged

Tests electronics/electric_conductivity.py #9943 #12437

merged 9 commits into from
Dec 30, 2024

Conversation

juliaaragao
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

imSanko
imSanko suggested changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@imSanko imSanko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes

cclauss
cclauss reviewed Dec 30, 2024
View reviewed changes
conversions/rec_to_pol.py Outdated Show resolved Hide resolved
cclauss
cclauss reviewed Dec 30, 2024
View reviewed changes
conversions/rec_to_pol.py Outdated Show resolved Hide resolved
cclauss
cclauss reviewed Dec 30, 2024
View reviewed changes
conversions/rec_to_pol.py Outdated Show resolved Hide resolved
cclauss
cclauss reviewed Dec 30, 2024
View reviewed changes
conversions/rec_to_pol.py Outdated Show resolved Hide resolved
cclauss
cclauss reviewed Dec 30, 2024
View reviewed changes
DIRECTORY.md Outdated Show resolved Hide resolved
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Dec 30, 2024
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Dec 30, 2024
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Dec 30, 2024
@cclauss cclauss enabled auto-merge (squash) December 30, 2024 12:36
cclauss
cclauss approved these changes Dec 30, 2024
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! A few changes for readability.

@cclauss cclauss merged commit a2be5ad into TheAlgorithms:master Dec 30, 2024
5 checks passed
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Dec 30, 2024
@cclauss cclauss mentioned this pull request Dec 30, 2024
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imSanko imSanko imSanko requested changes

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juliaaragao @cclauss @imSanko